Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3346] Create frontend for QA dashboard main landing page #2371

Open
wants to merge 14 commits into
base: al-ttahub-3316-3317-overview-widgets
Choose a base branch
from

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Sep 16, 2024

Description of change

  • Added widgets to the QA dashboard
  • Included a fair amount of refactoring to DRY up some of our widget/graph functionality

How to test

  • Confirm that the widgets on the QA dashboard, regional activity reports dashboard, and regional training reports dashboard all function appropriately and look correct

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod changed the title Mb/ttahub 3346/qa dashboard [TTAHUB-3346] Create frontend for QA dashboard main landing page Sep 18, 2024
@@ -152,7 +152,7 @@ function Menu({
<ul className="usa-list usa-list--unstyled" role="menu">
{menuItems.map((item) => (
<li key={item.label} role="menuitem">
<Button type="button" onClick={() => { updateShown(false); item.onClick(); }} unstyled className="smart-hub--menu-button smart-hub--button__no-margin">
<Button type="button" id={item.id || ''} onClick={() => { updateShown(false); item.onClick(); }} unstyled className="smart-hub--menu-button smart-hub--button__no-margin">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for uuid if its undefined?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, also cleaned up a bunch of stuff.

Might want one more pair of eyes as there are a lot of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants