-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTAHUB-3346] Create frontend for QA dashboard main landing page #2371
base: al-ttahub-3316-3317-overview-widgets
Are you sure you want to change the base?
[TTAHUB-3346] Create frontend for QA dashboard main landing page #2371
Conversation
…gets' into mb/TTAHUB-3346/qa-dashboard
@@ -152,7 +152,7 @@ function Menu({ | |||
<ul className="usa-list usa-list--unstyled" role="menu"> | |||
{menuItems.map((item) => ( | |||
<li key={item.label} role="menuitem"> | |||
<Button type="button" onClick={() => { updateShown(false); item.onClick(); }} unstyled className="smart-hub--menu-button smart-hub--button__no-margin"> | |||
<Button type="button" id={item.id || ''} onClick={() => { updateShown(false); item.onClick(); }} unstyled className="smart-hub--menu-button smart-hub--button__no-margin"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense for uuid if its undefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, also cleaned up a bunch of stuff.
Might want one more pair of eyes as there are a lot of changes.
Description of change
How to test
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy