-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTAHUB-2808]link historical objectives to templates #2354
base: main
Are you sure you want to change the base?
[TTAHUB-2808]link historical objectives to templates #2354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fairly good, But I think before we can attach/create templates for goals and objectives, the templates need to be deduped. There are currently 3 goal templates that have the same region and hash multiple times, similarly there are 95 objective templates that have same region and hash multiple times. To not exacerbate the issue, I think the duplicates would need to be removed after all references to them are replaced with the first instance of each of the templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very true and will have a new version with deduped templates in a bit.
Description of change
This links objectives (and now goals!) that should have been connected to a objective(goal) template to that template. In some cases where the template wasn't created, it also creates the template.
How to test
There's a built in results test at the end that should look like:
The goal results look like:
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy