Add first Activity Report fields #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stepper is removed for now. We will need to support out of order form entry, which the stepper doesn't support (and can't easily be updated to do so)
* Add skip link * Add navigation landmark * Activity report has proper heading structure
First activity report fields
rahearn
approved these changes
Oct 28, 2020
| <div className="usa-hint" id={hintId}>mm/dd/yyyy</div> | ||
| <Controller | ||
| render={({ onChange, value }) => ( | ||
| <ReactDatePicker |
There was a problem hiding this comment.
I was having a little bit of trouble with keyboard navigation of this component. I was able to get dates input, but it definitely wasn't clean.
Are there any known issues with it or known ways to improve the keyboard behavior?
There was a problem hiding this comment.
After playing around with it a bit it seems like there are ways to make the keyboard navigation nicer. Specifically the <Controller /> wrapper seems to mess with the navigation. If I use the straight <ReactDatePicker /> component I'm able to select dates easier with the keyboard.
rahearn
pushed a commit
that referenced
this pull request
Jan 19, 2021
…back Saving an activity report feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Kept the form split into separate files even though they all show on the same page to help with readability.
Limitations
How to test
Issue(s)
Checklist