Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework node macro #1942

Open
wants to merge 60 commits into
base: master
Choose a base branch
from
Open

Rework node macro #1942

wants to merge 60 commits into from

Conversation

TrueDoctor
Copy link
Member

No description provided.

Copy link

Found Clippy warnings

Clippy Warnings/Errors

warning: large size difference between variants
   --> node-graph/graph-craft/src/document/value.rs:27:3
    |
27  | /         pub enum TaggedValue {
28  | |             None,
29  | |             $( $(#[$meta] ) *$identifier( $ty ), )*
    | |                              ------------------ the largest variant contains at least 696 bytes
30  | |             RenderOutput(RenderOutput),
    | |             -------------------------- the second-largest variant contains at least 216 bytes
...   |
33  | |             EditorApi(Arc<WasmEditorApi>)
34  | |         }
    | |_________^ the entire enum is at least 0 bytes
...
115 | / tagged_value! {
116 | |     String(String),
117 | |     U32(u32),
118 | |     U64(u64),
...   |
180 | |     FontCache(Arc<graphene_core::text::FontCache>),
181 | | }
    | |_- in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
    = note: `-W clippy::large-enum-variant` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::large_enum_variant)]`
    = note: this warning originates in the macro `tagged_value` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider boxing the large fields to reduce the total size of the enum
    |
177 |     VectorModification(Box<graphene_core::vector::VectorModification>),
    |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: `graph-craft` (lib) generated 1 warning
warning: `graph-craft` (lib) generated 1 warning (1 duplicate)
warning: `graph-craft` (lib test) generated 1 warning (1 duplicate)
    Finished `dev` profile [optimized + debuginfo] target(s) in 5m 02s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants