Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update deprecated notificationConfig in healthcare api #12586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Sep 12, 2024

Description

Fixes b/310269530

Checklist

@noerog noerog requested review from a team as code owners September 12, 2024 01:49
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: healhcare labels Sep 12, 2024
@davidcavazos
Copy link
Contributor

File "/workspace/healthcare/api-client/v1/fhir/fhir_stores_test.py", line 244, in test_patch_fhir_store
    fhir_stores.patch_fhir_store(project_id, location, dataset_id, fhir_store_id)
TypeError: patch_fhir_store() missing 1 required positional argument: 'pubsub_topic'

Seems like the test needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: healhcare samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants