Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workbox-build): make source map filename consistent with injected source file #3234

Open
wants to merge 1 commit into
base: v7
Choose a base branch
from

Conversation

steverep
Copy link

Fixes #3233 per comments on #2239

  • Name the output source map simply swDest with .map appended
  • Replace the sourceMappingURL comment with the new filename
  • Adjust tests to use different filenames for input and output
  • Add simple test to check URL replacement

@steverep
Copy link
Author

@jeffposnick would it be possible to get your review here? I just don't want to build a pipeline using this patch if you feel it's a no go.

@jeffposnick
Copy link
Contributor

CC: @tropicadri and @petele for guidance.

@steverep
Copy link
Author

At this point I'm wondering if workbox is even being maintained anymore? It hasn't been touched in 6 months even for just responding to issues and dependency bumps.

@steverep
Copy link
Author

steverep commented Jun 6, 2024

@tomayac any chance this could get looked at soon? It's not exactly a very taxing review.

@tomayac
Copy link
Member

tomayac commented Jun 6, 2024

@tomayac any chance this could get looked at soon? It's not exactly a very taxing review.

At first sight this LGTM, but the tests fail. Could you look if it's related to this change? Thanks!

@steverep
Copy link
Author

steverep commented Jun 6, 2024

At first sight this LGTM, but the tests fail. Could you look if it's related to this change? Thanks!

I know they passed locally when I first created the PR but I'll take a quick look.

@steverep
Copy link
Author

steverep commented Jun 6, 2024

The same 8 tests fail on the v7 branch, so they have nothing to do with these changes.

@tomayac
Copy link
Member

tomayac commented Jun 6, 2024

The same 8 tests fail on the v7 branch, so they have nothing to do with these changes.

Thanks for checking! @tropicadri, over to you for a final look. I LGTM.

Copy link
Member

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approval.

Tests were manually verified to fail for unrelated reasons.

@steverep
Copy link
Author

@tropicadri are you able to review and release this change? I'd like to avoid creating a patch if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source map support for injectManifest makes incorrect assumptions
3 participants