deps: upgrade jest packages to 29.7.0 #16147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Aug 13, 2024
| @@ -41,7 +41,8 @@ describe('ExecutionContext', () => { | |||
| it('should clear context on frame navigations', async () => { | |||
| const executionContext = new ExecutionContext(sessionMock); | |||
|
|
|||
| const frameListener = sessionMock.on.mock.calls.find(call => call[0] === 'Page.frameNavigated'); | |||
| const frameListener = sessionMock.on.mock.calls | |||
| .find(call => call[0] === 'Page.frameNavigated') ?? []; | |||
There was a problem hiding this comment.
I don't understand this change. The test needs to ensure that frameListener is defined, but it's impossible to be undefined now that you added the ?? [].
adamraine
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types related to mocks went from any to something else - that's the cause of the bulk of the code changes.