Add a new setting to open links in a new window #5592
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: waiting for review
pakoito
commented
Aug 20, 2024
| if (mainWindow && mainWindow.webContents) { | ||
| mainWindow.webContents.send(IpcChannels.OPEN_URL, baseUrl(url)) | ||
| if (isOpenLinkInNewWindow()) { | ||
| createWindow({ replaceMainWindow: false, windowStartupUrl: startUrl, showWindowNow: true }) |
There was a problem hiding this comment.
This is probably an IPC to open a new window.
pakoito
commented
Aug 20, 2024
| @@ -820,7 +824,11 @@ function runApp() { | |||
|
|
|||
| ipcMain.once(IpcChannels.APP_READY, () => { | |||
| if (startupUrl) { | |||
| mainWindow.webContents.send(IpcChannels.OPEN_URL, startupUrl) | |||
| if (isOpenLinkInNewWindow()) { | |||
There was a problem hiding this comment.
This should probably check if there's already content on the window too.
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Pull Request Type
Related issue
Closes #1501
Description
It adds a global setting that makes
freetube://links be opened in a new windowScreenshots
Testing
I have not been able to pull the dependencies from yarn, as it errors in one of them. Thus, I have not been able to test the generation of the settings or whether the implementation is correct.
Desktop
Additional context
The PR is as-is for someone else to finalize and land.