fix build #1052
fix build #1052
Conversation
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>net48;net6.0</TargetFrameworks> | |||
| <TargetFrameworks>net48;net6</TargetFrameworks> | |||
There was a problem hiding this comment.
Why are you switching to an unusual TFM? I've never seen net6 being used anywhere.
There was a problem hiding this comment.
Maybe to test a bad csproj setting?
There was a problem hiding this comment.
It's not necessarily bad since it builds fine. Also, he made that change in 20 projects 🙂
|
i stuffed up the main branch with my auto update stuff. so this is just to get a green build going again and gradually re make the changes. basically nothing to see here for now |
| @@ -7,7 +7,7 @@ | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" PrivateAssets="all" /> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.0" PrivateAssets="All" /> | |||
| <PackageReference Include="Nullable.Extended.Analyzer" Version="1.15.6169" PrivateAssets="all" /> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" PrivateAssets="All" /> | |||
There was a problem hiding this comment.
Oh, I didn't notice this earlier, but I think the Microsoft.CodeAnalysis.CSharp package should be rolled back to v4.0.1 and frozen at that version unless there's a good reason to use a newer one, since referencing a newer version requires the user to have a .NET SDK or Visual Studio version which supports it. See here for the version map.
The problem is that it won't play along with tools which always suggest to bump the packages to the latest versions. 😞
No description provided.