Feature/do concurrent #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added github workflow for multithreaded builds and tests with 4 threads.
* amdflang compiler fails at this reference, for some reason...
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Coverage from Noether. I'm going to try adjusting the directory to |
It looks like ctest is exiting prematurely in github actions leading to low coverage (possibly?)
The tests appear to be running shorter than they should but we're not getting a failure in the ctests. I noticed that WORKSPACE was not set, which should definitely cause a problem for any of the mapped* tests.
|
@garrettbyrd - This one's ready for your review. I think I've got the coverage issue sorted out as well ( #50 ) |
garrettbyrd
reviewed
Sep 6, 2024
garrettbyrd
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #51
OpenMP pragmas have been completely removed. Computationally heavy loops for 1D, 2D, and 3D have all been replaced with equivalent
do concurrentblocks.The CMake build system has been updated to include two new options (1)
SELF_ENABLE_MULTITHREADINGand (2)SELF_MULTITHREADING_NTHREADS. Help descriptions are included in theCMakeLists.txtfile.I've tested on Noether and on a local workstation with a [email protected] stack using 4 threads for parallelism.