Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor error handling. #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattcollier
Copy link

The async sendAlert() function call on L46 does not work as intended with the try/catch block that surrounds it. I believe this inspired the additional try/catch block inside sendAlert itself.

https://github.com/Entle/action-pagerduty-alert/blob/main/index.js#L46

This PR is one possible remedy to this redundant code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant