Add extra configuration options to gRPC #7672
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Description
I've added a few configuration options to the gRPC-plugin.
grpc-ip-address
: I've changed the default ip-address to which the gRPC interface will bind from0.0.0.0
to127.0.0.1
. This new default should be more secure. Users who need to access the gRPC-interface externally can setgrpc-ip-address
to the port they like. Users can also configure an IPv6 address.grpc-scheme
: Previously, the gRPC connection only allowed https over mTLS. Configurting mTLS is somewhat cumbersome. Users that only need the gRPC interface locally can now setgrpc-scheme=http
. This will only work ifgrpc-ip-address
is set to a loopback address (127.0.0.1 or equivalent for IPv6).Related Issues
cln-grpc
: Specify a host and port #7654Changes Made
Checklist
Ensure the following tasks are completed before submitting the PR:
TODOs
have been addressed or removed.Additional Notes
Any additional information or context about this PR that reviewers should know.