exposesecret: a way to back up the hsm_secret via rpc (if enabled!) #7647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/exposesecret-plugin
branch
from
9272d46
to
8a68385
Compare
niftynei
reviewed
Sep 6, 2024
| - int: parsed as a signed integer (64-bit) | ||
| - flag: no-arg flag option. Presented as `true` if config specifies it. | ||
| - `string`: a string | ||
| - `string-conceal`: a string which will appear as "..." in `listconfigs`. |
ShahanaFarooqui
force-pushed
the
guilt/exposesecret-plugin
branch
2 times, most recently
from
f9a25b8
to
1a44756
Compare
Being able to back up the hsm_secret is critical, but you cannot do this through a UI, because of course we do not allow such access. People have lost funds because they didn't back up. This allows access to the hsm_secret if you use a password set in the config file. (If it's not set, the command does not work). This is a compromise, of course. Changelog-Added: `exposesecret` command for encouraging hsm_secret backups. Signed-off-by: Rusty Russell <[email protected]>
Gives us more room for user bits in opt. Signed-off-by: Rusty Russell <[email protected]>
…uld be concealed. And use it for `exposesecret-passphrase`. This is probably overly cautious, but it makes me feel a little better that we won't leak it to someone with read-only access. Signed-off-by: Rusty Russell <[email protected]>
ShahanaFarooqui
force-pushed
the
guilt/exposesecret-plugin
branch
from
1a44756
to
ad422bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As co-programmed with @ShahanaFarooqui .
If you set
exposesecret-passphraseyou can use that to retrieve the hsm_secret using theexposesecretcommand. It doesn't handle encrypted hsm secrets (if you're prepared type in the secret on every start, you don't want this).