askrene: fixup fee computation #7639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
force-pushed
the
askrene-fixup
branch
from
b8aaca0
to
661412e
Compare
Changelog-EXPERIMENTAL: fixup to askrene to compute fees on routes correctly. Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
force-pushed
the
askrene-fixup
branch
from
661412e
to
2fbfa76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Askrene fixup fee computation
Description
I checked that askrene is wrongly computing the amounts in the hops due to premature fee computation.
I added a couple of regression tests and modified existing tests.
Related Issues
Changes Made
Checklist
Ensure the following tasks are completed before submitting the PR:
TODOshave been addressed or removed.Additional Notes