Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for items larger than viewport #110

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robwebdev
Copy link

This builds on #88 with a couple of additions:

  1. Rebased against master to fix merge conflicts
  2. Fixes a bug in the isAxisInViewport when the element is larger than the viewport

rhengeveld and others added 3 commits November 1, 2017 10:46
For each axis (X,Y) the item is considered in the viewport when:  
- It's dimensions are fully within the viewport (original calculation)
- It's dimension are fully outside the viewport (new)

So the behaviour only changes for items that are actually taller/wider :)

This probably also fixes DockYard#37
@snewcomer
Copy link
Collaborator

@robwebdev If this is still applicable with the 3.0 version, I would love to help tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants