Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCESSINT-53 Add user, team as supported principal in terraform restriction_policy doc #2582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanjaythakkar-dd
Copy link
Contributor

@sanjaythakkar-dd sanjaythakkar-dd commented Sep 14, 2024

Update documentation for restriction_policy resource to specify user and team support as principal in bindings

@sanjaythakkar-dd sanjaythakkar-dd force-pushed the sanjay.thakkar/ACCESSINT-53-RP-Tf-Doc branch from 4c6f631 to 4de0711 Compare September 14, 2024 05:06
@sanjaythakkar-dd sanjaythakkar-dd requested a review from a team as a code owner September 14, 2024 05:06
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion, thanks!

@@ -51,7 +51,7 @@ Note: Dashboards support is in private beta. Reach out to your Datadog contact o

Required:

- `principals` (Set of String) An array of principals. A principal is a subject or group of subjects. Each principal is formatted as `type:id`. Supported types: `role` and `org`. The org ID can be obtained through the api/v2/users API.
- `principals` (Set of String) An array of principals. A principal is a subject or group of subjects. Each principal is formatted as `type:id`. Supported types: `team` , `role` , `org` and `user`. The org ID can be obtained through the api/v2/users API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `principals` (Set of String) An array of principals. A principal is a subject or group of subjects. Each principal is formatted as `type:id`. Supported types: `team` , `role` , `org` and `user`. The org ID can be obtained through the api/v2/users API.
- `principals` (Set of String) An array of principals. A principal is a subject or group of subjects. Each principal is formatted as `type:id`. Supported types: `team` , `role` , `org`, and `user`. The org ID can be obtained through the api/v2/users API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants