[do not merge] Allow optional converters #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgoldrbx
commented
Dec 11, 2017
| @@ -3,6 +3,8 @@ import { validateConverters, visitNode } from './helpers'; | |||
|
|
|||
| const ERR_INVALID_XML = 'XMLToReact: Unable to parse invalid XML input. Please input valid XML.'; | |||
|
|
|||
| const noop = () => {}; | |||
There was a problem hiding this comment.
noop and throwError could move to helpers?
pgoldrbx
commented
Dec 11, 2017
| @@ -56,7 +60,6 @@ export default class XMLToReact { | |||
| return null; | |||
| } | |||
|
|
|||
| return visitNode(tree.documentElement, 0, this.converters, data); | |||
| return visitNode(tree.documentElement, 0, this.converters, data, this.onConverterNotFound); | |||
There was a problem hiding this comment.
5 params... i don't love it
pgoldrbx
commented
Dec 17, 2017
| @@ -82,7 +82,7 @@ export function getChildren(node) { | |||
| * @return {Object} React element | |||
| * @private | |||
| */ | |||
| export function visitNode(node, index, converters, data) { | |||
| export function visitNode(node, index, converters, data, onConverterNotFound) { | |||
There was a problem hiding this comment.
I think i'll change the function signature to something like (node, {/*the rest*/}) but i can try that on master
|
closing as abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial PoC to allow for default pass-through conversion of nodes (see #10)
I'm making this available for early feedback.
Dependencies
Outstanding tasks