Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add register student use case #60

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

OctaviPascual
Copy link

@OctaviPascual OctaviPascual commented Nov 8, 2020

[WIP]
I'm using this branch to implement each of the features of each step.

import java.util.Objects;

public abstract class EmailValueObject {
private static final EmailValidator emailValidator = new EmailValidator();
Copy link
Author

@OctaviPascual OctaviPascual Nov 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better approach would be to create an EmailValidator interface to not contaminate our domain with this dependency, but I tried to do it and I didn't manage to inject the implementation into this abstract class. Is it possible to do it?

@OctaviPascual OctaviPascual marked this pull request as draft November 11, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant