Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding current mbi join for matching counts #1339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sadibhatla
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/AB2D-6134

🛠 Changes

Updated the SQL's to include join with Current MBI

ℹ️ Context for reviewers

Database retrieved and queued counts are mismatching most likely due to some missing joins with current MBIs for opt outs

✅ Acceptance Validation

No pipeline is broken and jobs still run fine

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@Sadibhatla Sadibhatla requested a review from a team as a code owner May 31, 2024 18:09
Copy link
Contributor

@Rwolfe-Nava Rwolfe-Nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really picky because the "AS" keyword is optional, but we use it in other places (like CoverageSearchEventRepository.java). So for consistency I would suggest adding it:

SELECT COUNT(*) FROM coverage AS c ...

That said, I am approving because this is fine as is.

@Sadibhatla
Copy link
Contributor Author

https://github.com/CMSgov/ab2d/blob/f6738fe245fb786296560b59741fa99ff2f170a1/coverage/src/main/java/gov/cms/ab2d/coverage/repository/CoverageServiceRepository.java

In this file where I made the changes "AS" is not used in other places and its completely optional Richard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants