Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Metadata Fields (Issue #58) #92

Merged
merged 40 commits into from
Dec 11, 2023
Merged

Conversation

ankushkgupta2
Copy link
Contributor

Description

Please Describe the Bug(s) Fixed and/or the Feature(s) Added:
Added functionality to read in a user provided .JSON file, containing custom field names, and perform various checks they would like carried out (sample names, data type to convert, rename the field, and default value to place).

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • Did you check for sensitive data, and remove any?
  • If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:
No.

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:
No.

ankushkgupta2 and others added 29 commits August 24, 2023 14:39
Updated readme for bakta integration
…stom_field_values and custom_field_types (both are list types)
…d contains sample names to apply custom field checks to
…tain configurations within the custom fields yaml/json
…validation_outputs/, just to mitigate for testing reasons... need to eventually clean up this .gitignore file to be much cleaner and simpler
…clues the modified metadata sample sheet with custom fields and an example .json file
@ankushkgupta2 ankushkgupta2 self-assigned this Dec 11, 2023
@kyleoconnell kyleoconnell merged commit e2204a7 into dev Dec 11, 2023
1 check failed
@kyleoconnell
Copy link
Collaborator

Fails CI because of bad param CLI_LIFTOFF, this needs to be patched.

@ankushkgupta2 ankushkgupta2 deleted the 58-internal-dynamic-metadata branch December 28, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants