Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Fix (Hotfix) (Issue #68) #86

Merged
merged 8 commits into from
Dec 6, 2023
Merged

CI Fix (Hotfix) (Issue #68) #86

merged 8 commits into from
Dec 6, 2023

Conversation

ankushkgupta2
Copy link
Contributor

@ankushkgupta2 ankushkgupta2 commented Nov 29, 2023

Description

Please Describe the Bug(s) Fixed and/or the Feature(s) Added:
The CI was breaking due to a simple syntax issue in the command that creates the test mamba environment, within the workflow file. More specifically, it was resolved by removing the extra "python=3.9" at the end of the command, which is not necessary since it is being created before separately within the workflow .yaml file.

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • Did you check for sensitive data, and remove any?
  • If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:
N/A

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:
No.

@ankushkgupta2 ankushkgupta2 self-assigned this Nov 29, 2023
@ankushkgupta2 ankushkgupta2 changed the title Ci test CI Fix (Hotfix) Nov 29, 2023
@ankushkgupta2 ankushkgupta2 linked an issue Dec 6, 2023 that may be closed by this pull request
1 task
@ankushkgupta2 ankushkgupta2 changed the title CI Fix (Hotfix) CI Fix (Hotfix) (Issue #68) Dec 6, 2023
@kyleoconnell kyleoconnell merged commit 19bb739 into master Dec 6, 2023
@kyleoconnell kyleoconnell deleted the ci_test branch December 6, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal] [Bug] Mamba Environment Issue for CI Workflow
2 participants