Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FASTQ / .GZ Fix (Issue #44) #57

Merged
merged 11 commits into from
Jul 13, 2023
Merged

FASTQ / .GZ Fix (Issue #44) #57

merged 11 commits into from
Jul 13, 2023

Conversation

ankushkgupta2
Copy link
Contributor

@ankushkgupta2 ankushkgupta2 commented Jun 29, 2023

Description

Please Describe the Bug(s) Fixed and/or the Feature(s) Added:

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • Did you check for sensitive data, and remove any?
  • If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:
No

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:
No

…abstracted out the retrieval of fasta sample names used in metadata validation + created a static function for configuring file permissions when opening them (including other meta properties)
…utility script, as a method under the MainUtility class, which is now being imported within the script as well
…nput for the input fasta, and it is now testing .fq.gz file
… file and zipped them + changed the delimiter of > used in a .fasta file to the @ symbol instead
@ankushkgupta2 ankushkgupta2 self-assigned this Jun 29, 2023
@ankushkgupta2 ankushkgupta2 linked an issue Jun 29, 2023 that may be closed by this pull request
@ankushkgupta2 ankushkgupta2 reopened this Jun 29, 2023
@ankushkgupta2 ankushkgupta2 changed the title 44 internal bug fasta.gz FASTQ / .GZ Fix (Issue #44) Jul 11, 2023
Copy link
Collaborator

@kyleoconnell kyleoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using biopython for fasta parsing. May also be some functions in biopython for handling fasta .gz

@kyleoconnell
Copy link
Collaborator

Meant fastq.gz

@kyleoconnell kyleoconnell merged commit 847bc0e into master Jul 13, 2023
1 check passed
@ankushkgupta2 ankushkgupta2 deleted the 44-internal-bug-fasta.gz branch August 10, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal] [Bug] Check Multiple .GZ FASTA Files Compatibility
2 participants