Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #2402

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[pre-commit.ci] pre-commit autoupdate #2402

wants to merge 2 commits into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 19, 2024 •
edited
Loading

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from f4a3a40 to 1d1f654 Compare September 2, 2024 21:21
@JNygaard-Skylight
Copy link
Collaborator

JNygaard-Skylight commented Sep 16, 2024 •
edited
Loading

This is failing because, with the update to ruff, it is now flagging issues within Jupyter notebooks that it previously was not. We have three options.

  1. Fix the issues in the notebooks.
  2. Ignore notebooks in totality or just the ones failing.
  3. Get rid of the notebooks.

I would vote to ignore them because I genuinely do not know what these notebooks are for, so I can not confidently fix them or see if they can be removed.

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
2d3c509 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.7 → v0.6.5](astral-sh/ruff-pre-commit@v0.5.7...v0.6.5)
- [github.com/pre-commit/mirrors-eslint: v9.9.0 → v9.10.0](pre-commit/mirrors-eslint@v9.9.0...v9.10.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JNygaard-Skylight