Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-8160] Use Desktop Filter Styles on Mobile #1472

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

adamdoe
Copy link
Collaborator

@adamdoe adamdoe commented Aug 21, 2024

Testing Steps

  1. Open the editor Panel > Filters Accordion
  2. Check the box to keep filter styles on mobile
  3. Ensure desktop styles are applied on mobile screens

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@adamdoe adamdoe changed the title Feature/dev 8160 [DEV-8160] Use Desktop Filter Styles on Mobile Aug 21, 2024
@joshlacey
Copy link
Collaborator

@adamdoe I'm not seeing anywhere in the ticket that there is a request for a toggle. If anything I would think you should make all future configs default to use the original dropdowns unless on mobile.

The real UX solution here is to make sure each control is mobile friendly. IDK why we're doing all these checks after the fact.

@adamdoe adamdoe added this to the 4.24.9 milestone Aug 21, 2024
@adamdoe
Copy link
Collaborator Author

adamdoe commented Aug 21, 2024

The original UX ask was to default to dropdowns on mobile. This is so that users can choose to keep the desktop experience.

@adamdoe adamdoe added the Hold label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants