Add cleanup of observers on destroy

BryanCrotaz · Aug 25, 2015 · de88b48 · de88b48
1 parent 32f6f23
commit de88b48
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/addon/mixins/csp-style.js b/addon/mixins/csp-style.js
@@ -99,6 +99,18 @@ export default Ember.Mixin.create({
 		this._refreshBindings();
 	}),
 
+	doCleanup: Ember.on('willDestroyElement', function() {
+		var observers = this.get('_styleObservers') || {};
+		// remove all bindings
+		for(var property in observers) {
+			if (observers.hasOwnProperty(property)) {
+				observers[property].stop();
+				delete observers[property];
+			}
+		}
+		this.set('_styleObservers', {});
+	}),
+
 	_refreshBindings: function() {
 
 		var hashCode = function(s){

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ember-cli-csp-style",
-  "version": "1.13.9",
+  "version": "1.13.10",
   "description": "",
   "directories": {
     "doc": "doc",