Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NpmLite Feature #2992

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

rejain456
Copy link

@rejain456 rejain456 commented Sep 5, 2024

Reason for Change:

This pr adds code changes for a new feature called NPM-Lite which is a subset of NPM.
NPM Lite provides Singularity team with a “light” NPM which addresses:

  • Heavy load on API Server: NPM Lite must support ~4K Nodes (NPM currently supports ~250 Nodes).
  • Windows NPM performance issues caused by HNS SetPolicies.

Issue Fixed:

To make npm more scalable for the singularity team, npm lite consists of 2 main limitations:

  1. Only accepts CIDR-based network policies
  2. Enables the daemon set to watch for pods only under its node

This pr adds code to cover both the points above

Requirements:

Notes:

@rejain456 rejain456 requested a review from a team as a code owner September 5, 2024 20:38
Copy link
Contributor

@huntergregory huntergregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIDR check looks good. Wondering if we can/should scope the informer change to pod controller

npm/cmd/start.go Outdated Show resolved Hide resolved
npm/cmd/start.go Outdated Show resolved Hide resolved
npm/npm.go Outdated Show resolved Hide resolved
@rejain456
Copy link
Author

CIDR check looks good. Wondering if we can/should scope the informer change to pod controller

@huntergregory
Copy link
Contributor

/azp run Azure Container Networking PR

@huntergregory
Copy link
Contributor

/azp run NPM Conformance Tests

Copy link

No pipelines are associated with this pull request.

@huntergregory
Copy link
Contributor

/azp run NPM Scale Test

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

No pipelines are associated with this pull request.

@rejain456
Copy link
Author

/azp run Azure Container Networking PR

Copy link

Commenter does not have sufficient privileges for PR 2992 in repo Azure/azure-container-networking

@rejain456
Copy link
Author

/azp run NPM Conformance Tests

Copy link

Commenter does not have sufficient privileges for PR 2992 in repo Azure/azure-container-networking

@Azure Azure deleted a comment from azure-pipelines bot Sep 9, 2024
@sheylatrudo
Copy link
Contributor

/azp run NPM Conformance Tests

Copy link

No pipelines are associated with this pull request.

@rejain456
Copy link
Author

/azp run Azure Container Networking PR

Copy link

Commenter does not have sufficient privileges for PR 2992 in repo Azure/azure-container-networking

@rejain456 rejain456 mentioned this pull request Sep 9, 2024
4 tasks
@rejain456
Copy link
Author

/azp run Azure Container Networking PR

Copy link

Commenter does not have sufficient privileges for PR 2992 in repo Azure/azure-container-networking

@rejain456
Copy link
Author

/azp run Azure Container Networking PR

Copy link

Commenter does not have sufficient privileges for PR 2992 in repo Azure/azure-container-networking

@rejain456
Copy link
Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rejain456
Copy link
Author

/azp run NPM Scale Test

@rejain456
Copy link
Author

/azp run NPM Conformance Tests

Copy link

No pipelines are associated with this pull request.

1 similar comment
Copy link

No pipelines are associated with this pull request.

@rejain456 rejain456 marked this pull request as draft September 10, 2024 23:05
@jpayne3506
Copy link
Contributor

/azp

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@jpayne3506
Copy link
Contributor

/azp list

@jpayne3506
Copy link
Contributor

/azp list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants