fix: add placeholder os version value for linux docker build

[QxBytes]

Reason for Change:

If in the pipelines a linux agent cannot find buildah (for some reason), it falls back to docker. Docker expects non-empty build args. In linux, OS_VERSION is not used, so we don't populate it, but docker needs some value for it, or there will be an error. So, if the value is not set, we put a placeholder value so there is no error in linux. In windows, we DOCKER_OS_VERSION just becomes the value of OS_VERSION like normal. The ARG OS_VERSION=none is not necessary but takes care of some of the dockerfile warnings.

Issue Fixed:

See above

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• relevant PR labels added

Notes:

[rbtr]

I am concerned that sometimes the pipelines use docker, and sometimes buildah. Pipeline runs should be reproducible and this inconsistency is not acceptable. I would rather explicitly set the CONTAINER_BUILDER=buildah and have the pipeline fail if it is not present, than have it silently use a different builder.

[timraymond]

Agree w/ @rbtr. I would go so far as to argue for alias docker="bash -c 'exit 1'"

[rbtr]

For some context, I set the Makefile up to fall back to Docker so that it would work locally and wouldn't require everyone to install Buildah for development. The CI was always supposed to use the Containers tools.

[github-actions]

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

[github-actions]

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

[github-actions]

Pull request closed due to inactivity.