feat: adding stateless CNI pipeline test #2914

behzad-mir · 2024-08-12T17:27:46Z

Reason for Change:
Adding a pipline test for stateless CNI to check the cns State and the datapath

uses conventional commit messages
includes documentation
adds unit tests
relevant PR labels added

Notes:

.pipelines/cni/pipeline.yaml

.pipelines/cni/singletenancy/cniv2-stateless-template.yaml

.pipelines/pipeline.yaml

...singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-step-template.yaml

test/integration/manifests/cnsconfig/azurestatelesscnioverlaywindowsconfigmap.yaml

.pipelines/pipeline.yaml

.../singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-job-template.yaml

...singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-step-template.yaml

test/internal/kubernetes/utils_create.go

test/validate/windows_validate.go

test/validate/linux_validate.go

test/validate/windows_validate.go

.pipelines/cni/pipeline.yaml

behzad-mir · 2024-08-14T20:16:54Z

.../singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-job-template.yaml

+
+      - job: ${{ parameters.name }}_windows
+        displayName: Azure CNI Overlay Test Suite | Windows - (${{ parameters.name }})
+        dependsOn: ${{ parameters.name }}_linux


need to modify the depends on after ewmoving linux stages

behzad-mir · 2024-08-14T20:17:12Z

.../singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-job-template.yaml

+      - job: failedE2ELogs_linux
+        displayName: "Linux Failure Logs"
+        dependsOn:
+          - ${{ parameters.name }}_linux


removing this

behzad-mir · 2024-08-14T20:22:12Z

...singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-step-template.yaml

+        scriptType: "bash"
+        addSpnToEnvironment: true
+        inlineScript: |
+          set -e


Will add nodepool after the cluster creation

behzad-mir · 2024-08-14T20:23:54Z

...singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-step-template.yaml

+    name: "kubeconfig"
+    displayName: "Set Kubeconfig"
+
+  - ${{ if eq(parameters.os, 'linux') }}:


the test belo need to be run on windows

QxBytes

Also would like to see a passing pipeline run to be sure

...singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-step-template.yaml

jpayne3506 · 2024-08-26T18:04:56Z

...singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-step-template.yaml

+    - script: |
+        echo "validate pod IP assignment before CNS restart"
+        kubectl get pod -owide -A
+        echo "validate pod state before CNS restarts"
+        cd test/integration/load
+        CNI_TYPE=stateless go test -timeout 30m -tags load -run ^TestValidateState$
+        kubectl rollout restart ds azure-cns -n kube-system
+        kubectl rollout status ds azure-cns -n kube-system
+        kubectl get pod -owide -A
+        echo "validate pods after CNS restart"
+        CNI_TYPE=stateless go test -timeout 30m -tags load -run ^TestValidateState$
+      name: "restartCNS_ValidatePodState"
+      displayName: "Restart CNS and validate pod state"
+      retryCountOnTaskFailure: 3


This test is contained within make test-load. Should be removed.

jpayne3506 · 2024-08-26T18:12:40Z

.pipelines/pipeline.yaml

+        clusterType: overlay-byocni-up
+        clusterName: "statelesswin"
+        vmSize: Standard_B2ms
+        k8sVersion: "1.30"


Note: this line should/will be removed once #2924 is merged.

jpayne3506 · 2024-08-26T18:22:34Z

cni/network/network.go

@@ -1125,18 +1126,23 @@ func (plugin *NetPlugin) Delete(args *cniSkel.CmdArgs) error {
 		// network ID is passed in and used only for migration
 		// otherwise, in stateless, we don't need the network id for deletion
 		epInfos, err = plugin.nm.GetEndpointState(networkID, args.ContainerID)
+		// if stateless CNI fail to get the endpoint from CNS for any reason other than  Endpoint Not found
+		if err != nil && !strings.Contains(err.Error(), "endpoint state could not be found in the statefile") {


Is there any way we can tie this back to the defined error message?

azure-container-networking/cns/restserver/ipam.go

Line 29 in 6b05df1

ErrEndpointStateNotFound = errors.New("endpoint state could not be found in the statefile")

QxBytes · 2024-08-26T22:03:36Z

test/validate/validate.go

+	for _, v := range cnsResult.Endpoints {
+		for ifName, ip := range v.IfnameToIPMap {
+			if ifName == "eth0" {
+				cnsPodIps[ip.IPv4[0].IP.String()] = v.PodName


just wanted to confirm that ip.IPv4 will always have at least 1 item in it?

QxBytes · 2024-08-26T22:22:52Z

.../singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-job-template.yaml

+      name: $(BUILD_POOL_NAME_DEFAULT)
+    jobs:
+      - job: ${{ parameters.name }}_windows
+        displayName: Azure CNI Overlay Test Suite | Windows - (${{ parameters.name }})


Can we mention in the display name that this is for stateless?

QxBytes · 2024-08-26T22:27:35Z

...singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-step-template.yaml

+    inputs:
+      kubectlVersion: latest
+
+  - task: AzureCLI@1


I believe we should only use AzureCLI@2 for anything new (also found below in this file)

QxBytes

Also, noticed there's a failure in the pipelines here but it doesn't fail the test, and here . The second failure I noticed occurs on other PRs (which we should look into at some point) but could we check the first is expected behavior?

github-actions · 2024-09-11T00:01:20Z

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

behzad-mir added the cni Related to CNI. label Aug 12, 2024

behzad-mir requested a review from a team as a code owner August 12, 2024 17:27

behzad-mir requested review from jaer-tsun, jpayne3506 and QxBytes August 12, 2024 17:27

behzad-mir force-pushed the statelessCNI-pipeline branch 4 times, most recently from 8784e66 to a00c923 Compare August 13, 2024 23:50

QxBytes reviewed Aug 14, 2024

View reviewed changes

jpayne3506 reviewed Aug 14, 2024

View reviewed changes

.pipelines/pipeline.yaml Outdated Show resolved Hide resolved

jpayne3506 requested changes Aug 14, 2024

View reviewed changes

behzad-mir commented Aug 14, 2024

View reviewed changes

behzad-mir force-pushed the statelessCNI-pipeline branch 6 times, most recently from 26e0c9f to 7e98835 Compare August 14, 2024 22:25

behzad-mir requested review from jpayne3506 and QxBytes August 14, 2024 23:39

QxBytes reviewed Aug 15, 2024

View reviewed changes

...singletenancy/azure-cni-overlay-stateless/azure-cni-overlay-stateless-e2e-step-template.yaml Outdated Show resolved Hide resolved

behzad-mir force-pushed the statelessCNI-pipeline branch 2 times, most recently from bf25b66 to a8a0251 Compare August 22, 2024 22:17

behzad-mir requested a review from a team as a code owner August 22, 2024 22:17

behzad-mir force-pushed the statelessCNI-pipeline branch 2 times, most recently from 1359ef1 to 5ba93d5 Compare August 23, 2024 01:55

behzad-mir force-pushed the statelessCNI-pipeline branch 3 times, most recently from 6a34418 to e47fd99 Compare August 23, 2024 23:10

jpayne3506 reviewed Aug 26, 2024

View reviewed changes

QxBytes requested changes Aug 26, 2024

View reviewed changes

QxBytes reviewed Aug 26, 2024

View reviewed changes

behzad-mir force-pushed the statelessCNI-pipeline branch from e47fd99 to 2fb9949 Compare August 27, 2024 19:12

github-actions bot added the stale Stale due to inactivity. label Sep 11, 2024

behzad-mir force-pushed the statelessCNI-pipeline branch from 2fb9949 to cea8d32 Compare September 11, 2024 22:37

github-actions bot removed the stale Stale due to inactivity. label Sep 12, 2024

behzad-mir added 5 commits September 12, 2024 10:59

feat: adding stateless CNI pipeline test

7403ed0

feat: making change for stateless CNI pipeline

af718c5

feat: addressing the comments

0267409

fix: fixing stateles cni yaml

ddead67

fix: stateless CNI delete fix

582ce3c

behzad-mir force-pushed the statelessCNI-pipeline branch from cea8d32 to 582ce3c Compare September 12, 2024 17:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding stateless CNI pipeline test #2914

feat: adding stateless CNI pipeline test #2914

behzad-mir commented Aug 12, 2024

behzad-mir Aug 14, 2024

behzad-mir Aug 14, 2024

behzad-mir Aug 14, 2024

behzad-mir Aug 14, 2024

QxBytes left a comment

jpayne3506 Aug 26, 2024 •

edited

Loading

jpayne3506 Aug 26, 2024

jpayne3506 Aug 26, 2024

QxBytes Aug 26, 2024

QxBytes Aug 26, 2024

QxBytes Aug 26, 2024

QxBytes left a comment

github-actions bot commented Sep 11, 2024

feat: adding stateless CNI pipeline test #2914

Are you sure you want to change the base?

feat: adding stateless CNI pipeline test #2914

Conversation

behzad-mir commented Aug 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

QxBytes left a comment

Choose a reason for hiding this comment

jpayne3506 Aug 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

QxBytes left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 11, 2024

jpayne3506 Aug 26, 2024 •

edited

Loading