feat: Move WASM to components.json #4969
Open
+11,932
−7,171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mossaka
reviewed
Sep 19, 2024
Mossaka
requested changes
Sep 19, 2024
Mossaka
reviewed
Sep 20, 2024
Mossaka
requested changes
Sep 20, 2024
| done | ||
| fi | ||
| for shim in "${shims_to_download[@]}"; do | ||
| chmod 755 "$containerd_wasm_filepath/containerd-${shim}-${binary_version}-v1" |
There was a problem hiding this comment.
Suggested change
| chmod 755 "$containerd_wasm_filepath/containerd-${shim}-${binary_version}-v1" | |
| chmod 755 "$containerd_wasm_filepath/containerd-shim-${shim}-${binary_version}-v1" |
| local shims_to_download=${3} | ||
| local binary_version="$(echo "${shim_version}" | tr . -)" | ||
|
|
||
| chmod 755 "$containerd_wasm_filepath/containerd-shim-spin-${binary_version}-v2" |
There was a problem hiding this comment.
Suggested change
| chmod 755 "$containerd_wasm_filepath/containerd-shim-spin-${binary_version}-v2" | |
| chmod 755 "$containerd_wasm_filepath/containerd-shim-spin-v2" |
Comment on lines
+271
to
+275
| for shim in "${shims_to_download[@]}"; do | ||
| retrycmd_if_failure 30 5 60 curl -fSLv -o "$containerd_wasm_filepath/containerd-shim-${shim}-${binary_version}-v1" "$containerd_wasm_url/containerd-shim-${shim}-v1" 2>&1 | tee $CURL_OUTPUT >/dev/null | grep -E "^(curl:.*)|([eE]rr.*)$" && (cat $CURL_OUTPUT && exit $ERR_KRUSTLET_DOWNLOAD_TIMEOUT) & | ||
| WASMSHIMPIDS+=($!) | ||
| done | ||
| } |
There was a problem hiding this comment.
question: shouldn't this for loop be put in the else block since it's downloading from acs-mirror path, instead of MCR registry?
Comment on lines
+328
to
+330
| retrycmd_if_failure 30 5 60 curl -fSLv -o "$containerd_wasm_filepath/containerd-shim-spin-v2" "$containerd_wasm_url/containerd-shim-spin-v2" 2>&1 | tee $CURL_OUTPUT >/dev/null | grep -E "^(curl:.*)|([eE]rr.*)$" && (cat $CURL_OUTPUT && exit $ERR_KRUSTLET_DOWNLOAD_TIMEOUT) & | ||
| SPINKUBEPIDS+=($!) | ||
| } |
There was a problem hiding this comment.
Same question as above, shound't this be placed inside a else block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it: removing hard coded wasm version and acs-mirror url to components.json
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: