Fix RelativePanel implementation #16769
Open
+1,750
−527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does WinUI also have RelativePanel tests? It would be useful to port too. We don't have enough of them https://github.com/AvaloniaUI/Avalonia/blob/1f886594ee6a7585758c9694f6e620a100079c13/tests/Avalonia.Controls.UnitTests/RelativePanelTests.cs |
|
|
@cla-avalonia agree |
maxkatz6
reviewed
Aug 22, 2024
|
I'm still testing the behavior about RelativePanel |
This was referenced Aug 23, 2024
|
@maxkatz6 There seems be a layout issue in Avalonia Here, we try to arrange a control in a rect (0, 0, 0, 20), which means the area has no space.
But the control was still rendered. It should be clipped.
In WPF, that's totally ok:
Was Avalonia designed from the ground up with a different layout logic than WPF? Or, is this just a bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fix RelativePanel implementation
What is the current behavior?
Now RelativePanel has the same behavior as WinUI3
What is the updated/expected behavior with this PR?
Test the sample code mentioned in #16768
How was the solution implemented (if it's not obvious)?
Completely re-implement RelativePanel
Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #16768