ci: use pulsar in ci

[scagood]

No description provided.

[scagood]

The main thing I am unsure of is how to go about fixing the windows stuff 🤔

I figured I'd put the progress of mac + linux at least passing here though

[scagood]

I have no idea why this install does not work 😬

[savetheclocktower]

I think on Windows you've still got to use ppm instead of pulsar --package, so give that a shot. If that doesn't work, I'll summon another person from Pulsar core to help troubleshoot.

[scagood]

I initially tried to use ppm here, but it failed on macos.

I found that its disabled here, not sure why:
https://github.com/pulsar-edit/action-pulsar-dependency/blob/main/action.yml#L27

[savetheclocktower]

@confused-Techie, do you remember why? ^^

[confused-Techie]

This should only be commented out, in case someone wanted to symlink ppm, but the idea is we move fully over to using pulsar -p.

On a side note, @savetheclocktower is 100% right, you must still use apm on Windows. Plus the installer doesn't add anything to the path. You could run the tests from the path of the package after install, like I do here, when running on windows

[scagood]

mmm, I ended up using a patched version atom-package-deps to install the packages on windows 🤔
For reference, both ppm, and pulsar -p did not install the package
I probably need to work out a better solution 😬

[savetheclocktower]

Thank you so very much for doing this.

Looks like you got Windows working — are we good to land this PR?

[savetheclocktower]

Ah, I see some of the tests are still skipped. Never mind.

[scagood]

This is just because the ppm install linter-eslint just does not seem to install linter-eslint. So the tests all throw an error saying as much.

See: https://github.com/scagood/linter-eslint-node/actions/runs/5484423520/jobs/9991948934

[savetheclocktower]

Maybe try installing from GitHub just for fun?

ppm install AtomLinter/linter-eslint

[savetheclocktower]

Oh, the package path in package-integration-spec.js is still hard-coded:

const packagesRoot = Path.join(root, '.atom', 'packages');

Try switching that to .pulsar.

[scagood]

@savetheclocktower What do you think of the hack for installing deps on windows?

If its reasonable we could look to merge this. May see if I can get a windows machine and also try to fix ppm/pulsar -p

[scagood]

TODO: Create a package for this (probably called pulsar-package-deps)

Maybe we should put that in the pulsar org 🤔

[UziTech]

Or you could start the pulsar-community org. I could transfer any packages from atom-community and AtomLinter that you want.

[savetheclocktower]

@confused-Techie, once again I summon thee: does pulsar-package-deps make sense to be hosted by the Pulsar org, or should it be somewhere else?

[scagood]

pulsar-package-deps changes found in this commit -- pulsar-linter/package-deps@0bad339

Let me know what we want doing with it.

I am also considering bumping all the package version see: https://github.com/steelbrain/package-deps/pulls

[scagood]

@savetheclocktower Should we progress this PR?

[savetheclocktower]

Looks like we're good. I'll land this and then you can rebase #38 and #41. Thanks a lot!

Another thing we should tackle in the future is automatic release to the Pulsar Package Repository, but that might require some small amount of @UziTech's time just to work out how to generate and store a secret token. It can wait.