Support cpufreq for t6031 #367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to work, and matches the info i can find. Signed-off-by: Daniel Berlin <[email protected]>
aruediger
reviewed
Dec 1, 2023
| @@ -262,6 +280,8 @@ const struct feat_t *cpufreq_get_features(void) | |||
| case T6021: | |||
| case T6022: | |||
| return t6020_features; | |||
| case T6031: | |||
| return t6031_features; | |||
There was a problem hiding this comment.
For now, yes. I assume it will end up slightly different in the end, which is why i didn't reuse the struct.
|
I'm not comfortable merging this until we at least confirm via macOS HV trace that it does the same thing. Getting this wrong has bit us hard in the past (M2 core lockups on deep sleep) and it's a huge nightmare to debug. We're going to need the HV for a lot of other stuff on M3 anyway, so there isn't much point in bringing up Linux cpufreq until that works. |
|
That's fine.
…On Sun, Dec 3, 2023 at 3:41 AM Hector Martin ***@***.***> wrote:
I'm not comfortable merging this until we at least confirm via macOS HV
trace that it does the same thing. Getting this wrong has bit us *hard*
in the past (M2 core lockups on deep sleep).
—
Reply to this email directly, view it on GitHub
<#367 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACPI2Z57JWAUTG2J2KVH7DYHQ3LLAVCNFSM6AAAAABACCXDN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGQYTAOJXGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Note: I traced enough of the kext now to verify that this is at least as correct as the current other code :) But I still agree we should basically leave it disabled until we have lots of other stuff working, just to eliminate variables. |
marcan
force-pushed
the
main
branch
3 times, most recently
from
4f95305
to
95d67cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work, and matches the info i can find.
Signed-off-by: Daniel Berlin [email protected]