Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new markdown file for AeroRust docs (Issue#3 Resolution Attempt) #10

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

prakritishetty
Copy link
Contributor

No description provided.

@prakritishetty
Copy link
Contributor Author

@elpiel could you have a look at this please?

@prakritishetty
Copy link
Contributor Author

Hi @elpiel , could you please check if this is fine? Actually I'm trying out hacktoberfest, and I really want to be in the 40,000 completing first, hence the slight urgency!

@elpiel
Copy link
Member

elpiel commented Oct 16, 2022

In general looks pretty good. I found a few places that need fixes as well asl a few typos.
I'll make sure to give a better feedback in the coming days.

Thanks you for working on this! It looka great 🤩

@prakritishetty
Copy link
Contributor Author

Oh! Will have a look at the typos till then, sorry!

@prakritishetty
Copy link
Contributor Author

@elpiel I fixed the grammatical errors, please have a look when free!

@prakritishetty
Copy link
Contributor Author

Hi @elpiel any update on this PR?

@elpiel
Copy link
Member

elpiel commented Oct 19, 2022

Yes, I will look into it today

@elpiel
Copy link
Member

elpiel commented Oct 20, 2022

I will merge it as it is but will make it a draft page and make some tweaks.
Thanks for working on the content!

@elpiel elpiel merged commit c3c3b73 into AeroRust:main Oct 20, 2022
@elpiel elpiel added the Hacktoberfest Issues suitable for Hacktoberfest label Oct 20, 2022
@elpiel elpiel added hacktoberfest-accpeted Hacktoberfest accepted PR and removed Hacktoberfest Issues suitable for Hacktoberfest labels Oct 20, 2022
@prakritishetty
Copy link
Contributor Author

Will keep a track of the tweaks and suggest some if anything else strikes me, cheers, thank you!

@elpiel
Copy link
Member

elpiel commented Oct 20, 2022

Will keep a track of the tweaks and suggest some if anything else strikes me, cheers, thank you!

Thank you.
We are looking to make a good onboarding process and this text might get into the website eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accpeted Hacktoberfest accepted PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content needed - What is AeroRust? Who is it for? What are the benefits of Rust? and more..
2 participants