-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated TrustedApplicationAccess on Macos Catalina #59
Conversation
I can confirm I can build again with this patch. Unfortunately, I don't know the implications of the changes though. |
fc8746d
to
eb070b6
Compare
Trying this out with aws-vault, I no longer get a password prompt when aws-vault accesses the keychain |
I believe the fact that aws-vault appears in the "always allow access" section is due to clicking on the 'always allow" button when entering the password. I rebuilt aws-vault with this PR and I get the following behaviour:
Now, I'm far from being an OSX expert so this should be taken with a grain of salt. |
The point is to ensure that the user is prompted to "Allow" or "Always Allow". This PR changes the behaviour so that aws-vault is in the trusted list of apps by default which means the user is not prompted and is not the desired behaviour |
Hi @mtibben! We would really like to use a version of keyring that has the updated go-keychain dependency. Would you accept a PR that only updates the dependency? |
Hey @genevieve, absolutely yes if we can demonstrate that it behaves the same way. I have not been able to confirm this yet so have committed db030e0 temporarily |
See the comment at #66 (comment) on how to address this issue. |
Updated keybase/go-keychain dependency to remove deprecation warnings about TrustedApplicationAccess on Macos Catalina
resolves #56