Merge pull request #27 from 99designs/stop-hinting-3rd-party-interface

Use RequestInterface instead of MessageInterface
99designs · Oct 17, 2016 · 1d64ff6 · 1d64ff6
2 parents 8183e22 + 46ceca5
commit 1d64ff6
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 19 deletions.
diff --git a/src/Algorithm.php b/src/Algorithm.php
@@ -6,9 +6,7 @@ abstract class Algorithm
 {
     /**
      * @param string $name
-     *
      * @return HmacAlgorithm
-     *
      * @throws Exception
      */
     public static function create($name)

diff --git a/src/Signature.php b/src/Signature.php
@@ -2,7 +2,7 @@
 
 namespace HttpSignatures;
 
-use Psr\Http\Message\MessageInterface;
+use Psr\Http\Message\RequestInterface;
 
 class Signature
 {
@@ -16,12 +16,12 @@ class Signature
     private $signingString;
 
     /**
-     * @param MessageInterface $message
+     * @param RequestInterface $message
      * @param Key $key
      * @param AlgorithmInterface $algorithm
      * @param HeaderList $headerList
      */
-    public function __construct(MessageInterface $message, Key $key, AlgorithmInterface $algorithm, HeaderList $headerList)
+    public function __construct($message, Key $key, AlgorithmInterface $algorithm, HeaderList $headerList)
     {
         $this->key = $key;
         $this->algorithm = $algorithm;

diff --git a/src/Signer.php b/src/Signer.php
@@ -2,7 +2,7 @@
 
 namespace HttpSignatures;
 
-use Psr\Http\Message\MessageInterface;
+use Psr\Http\Message\RequestInterface;
 
 class Signer
 {
@@ -28,10 +28,10 @@ public function __construct($key, $algorithm, $headerList)
     }
 
     /**
-     * @param MessageInterface $message
-     * @return MessageInterface
+     * @param RequestInterface $message
+     * @return RequestInterface
      */
-    public function sign(MessageInterface $message)
+    public function sign($message)
     {
         $signatureParameters = $this->signatureParameters($message);
         $message = $message->withAddedHeader("Signature", $signatureParameters->string());
@@ -40,7 +40,7 @@ public function sign(MessageInterface $message)
     }
 
     /**
-     * @param MessageInterface $message
+     * @param RequestInterface $message
      * @return SignatureParameters
      */
     private function signatureParameters($message)
@@ -54,7 +54,7 @@ private function signatureParameters($message)
     }
 
     /**
-     * @param MessageInterface $message
+     * @param RequestInterface $message
      * @return Signature
      */
     private function signature($message)

diff --git a/src/SigningString.php b/src/SigningString.php
@@ -16,7 +16,7 @@ class SigningString
      * @param HeaderList $headerList
      * @param RequestInterface $message
      */
-    public function __construct(HeaderList $headerList, RequestInterface $message)
+    public function __construct(HeaderList $headerList, $message)
     {
         $this->headerList = $headerList;
         $this->message = $message;

diff --git a/src/Verification.php b/src/Verification.php
@@ -2,11 +2,11 @@
 
 namespace HttpSignatures;
 
-use Psr\Http\Message\MessageInterface;
+use Psr\Http\Message\RequestInterface;
 
 class Verification
 {
-    /** @var MessageInterface */
+    /** @var RequestInterface */
     private $message;
 
     /** @var KeyStoreInterface */
@@ -16,10 +16,10 @@ class Verification
     private $_parameters;
 
     /**
-     * @param MessageInterface $message
+     * @param RequestInterface $message
      * @param KeyStoreInterface $keyStore
      */
-    public function __construct(MessageInterface $message, $keyStore)
+    public function __construct($message, KeyStoreInterface $keyStore)
     {
         $this->message = $message;
         $this->keyStore = $keyStore;

diff --git a/src/Verifier.php b/src/Verifier.php
@@ -2,7 +2,7 @@
 
 namespace HttpSignatures;
 
-use Psr\Http\Message\MessageInterface;
+use Psr\Http\Message\RequestInterface;
 
 class Verifier
 {
@@ -18,10 +18,10 @@ public function __construct(KeyStoreInterface $keyStore)
     }
 
     /**
-     * @param MessageInterface $message
+     * @param RequestInterface $message
      * @return bool
      */
-    public function isValid(MessageInterface $message)
+    public function isValid($message)
     {
         $verification = new Verification($message, $this->keyStore);