Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding entity resolver fix for entityResolver(multi: true) directive #3260

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RyanMcCabe-catapult
Copy link

A fix for the issue described in issue 3160. If the multi entity is used in any other resolver the error would always be thrown, now it is just skipped. The multi entity resolver has the directive set and runs it, the other resolvers don't have it set so it gets skipped and works as expected.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented Sep 9, 2024

Coverage Status

coverage: 56.722% (+0.05%) from 56.668%
when pulling 07d9d54 on RyanMcCabe-catapult:issue-3160/entity-resolver-fix
into cf42b25 on 99designs:master.

@clayne11
Copy link
Contributor

clayne11 commented Sep 12, 2024

@RyanMcCabe-catapult thanks for trying to fix this. This isn't the best way to implement this.

Inside of plugin/federation.go you should add entityResolver to the skipRuntime config. That way we don't have to add one-off changes to the shared template itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants