Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to override existing tags #2536 #2537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valllabh
Copy link
Contributor

@valllabh valllabh commented Jan 30, 2023

  • This fix honors user added tags in order they appear and overrides previous tags if any
  • tags are now sorted in alphabetical order to have more consistency
  • added extra tests post model generation

@StevenACoffman you might want to check this

I have:

  • [Yes] Added tests covering the bug / feature (see testing)
  • [Not Required] Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

Coverage: 75.576% (+0.003%) from 75.574% when pulling 4131f89 on valllabh:master into 356f4f9 on 99designs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants