WIP: Support macos touchid #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lox
force-pushed
the
support-macos-touchid
branch
2 times, most recently
from
a25c1cf
to
5e17a9c
Compare
lox
force-pushed
the
support-macos-touchid
branch
from
5e17a9c
to
6b90d34
Compare
Open
|
This needs to be upstreamed to |
|
@lox I know this was a while ago, but any further thoughts on / interest in this? I looked at https://github.com/99designs/keyring but there doesn't seem to be any issue there yet. Could probably pitch in a little work on this but would want to connect about approach 😄 Not critical, mainly an annoyance from what seems similar to #219 |
|
Also see #273 |
mtibben
force-pushed
the
master
branch
4 times, most recently
from
2fac4ce
to
d3cd285
Compare
|
This has bit-rotted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pass at touchid support. Passing in the
--biometricsflag will use touchid on compatible macOS hosts. The first time you do this we prompt for the master passphrase and then store it in the login keychain, along with the rights to access that item in future. Subsequent access is blocked by touch id, but after that we lookup the keychain password and use it to unlock the aws-vault keychain.I don't love the approach, but it closely matches 1password. Need to implement the extra security bits that they do too:
Also depends on #130.