Merge pull request #1194 from 99designs/bump-golangci-lint

Update golangci-lint

.github/workflows/go.yml

@@ -38,4 +38,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/[email protected]
         with:
-          version: v1.51.2
+          version: v1.52.0

cli/list.go

@@ -184,9 +184,5 @@ func ListCommand(input ListCommandInput, awsConfigFile *vault.ConfigFile, keyrin
 		fmt.Fprintf(w, "-\t-\t%s\t\n", s)
 	}
 
-	if err = w.Flush(); err != nil {
-		return err
-	}
-
-	return nil
+	return w.Flush()
 }

cli/proxy.go

@@ -9,7 +9,7 @@ import (
 	"github.com/alecthomas/kingpin/v2"
 )
 
-func ConfigureProxyCommand(app *kingpin.Application, a *AwsVault) {
+func ConfigureProxyCommand(app *kingpin.Application) {
 	stop := false
 
 	cmd := app.Command("proxy", "Start a proxy for the ec2 instance role server locally.").

main.go

@@ -23,7 +23,7 @@ func main() {
 	cli.ConfigureExportCommand(app, a)
 	cli.ConfigureClearCommand(app, a)
 	cli.ConfigureLoginCommand(app, a)
-	cli.ConfigureProxyCommand(app, a)
+	cli.ConfigureProxyCommand(app)
 
 	kingpin.MustParse(app.Parse(os.Args[1:]))
 }

vault/credentialprocessprovider_test.go

@@ -13,11 +13,11 @@ import (
 	ststypes "github.com/aws/aws-sdk-go-v2/service/sts/types"
 )
 
-func executeFail(process string) (string, error) {
+func executeFail(_ string) (string, error) {
 	return "", errors.New("executing process failed")
 }
 
-func executeGetBadJSON(process string) (string, error) {
+func executeGetBadJSON(_ string) (string, error) {
 	return "Junk", nil
 }
 

vault/keyringprovider.go

@@ -13,7 +13,7 @@ type KeyringProvider struct {
 	CredentialsName string
 }
 
-func (p *KeyringProvider) Retrieve(ctx context.Context) (aws.Credentials, error) {
+func (p *KeyringProvider) Retrieve(_ context.Context) (aws.Credentials, error) {
 	log.Printf("Looking up keyring for '%s'", p.CredentialsName)
 	return p.Keyring.Get(p.CredentialsName)
 }