Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphiQL tweaks #44

Open
bjunc opened this issue Jun 19, 2017 · 2 comments
Open

GraphiQL tweaks #44

bjunc opened this issue Jun 19, 2017 · 2 comments

Comments

@bjunc
Copy link

bjunc commented Jun 19, 2017

Few suggestions I'd like to make:

  1. Change the default tokenHeader from access-token to Authorization. I believe the majority of use-cases will be using Authorization: Bearer {JWT}.

  2. Remove the @Cache from the explorer controller. Is this really needed for dev?

  3. Change the route path to something that doesn't start with /graphql. I have /graphql behind a firewall pattern, which then blocks the explorer too. I've since changed the path to /_graphiql to match other dev related tools (eg. _profiler)

  4. Make the explorer a dedicated bundle that can added to the AppKernel based on environment (eg. DebugBundle and WebProfilerBundle).

@portey
Copy link
Contributor

portey commented Jun 19, 2017

Hi @bjunc,

I would like to add some notes:

  1. Let's make it as config parameter (of new budle).
  2. Yes, you can easily remove it, it's not necessary any more.
  3. Yes too.
  4. Absolutely yes. It would be great to add here else one extension for graphql Altair.

@bjunc
Copy link
Author

bjunc commented Jun 19, 2017

Sounds great! @portey what are the next steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants