Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Highcharts.Options type for ChartModel.highchartsConfig #3726

Open
amcclain opened this issue Jul 17, 2024 · 1 comment
Open

Use Highcharts.Options type for ChartModel.highchartsConfig #3726

amcclain opened this issue Jul 17, 2024 · 1 comment
Labels

Comments

@amcclain
Copy link
Member

Would want to look carefully around any complexities with extra modules or things like that, but this would be a big upgrade over our current bail-out to PlainObject when it comes to getting help writing and updating chart configs.

@amcclain amcclain added the types label Jul 17, 2024
@amcclain amcclain added this to the Quick Wins milestone Jul 30, 2024
@amcclain
Copy link
Member Author

Ah - the curse of "quick wins" strikes again...

So we deliberately don't import HC at all as a Hoist dep, to make it clear that any project / developers wishing to use it must review and properly license the library according to their terms.

@amcclain amcclain removed this from the Quick Wins milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant