Refactor Media3 bindings #956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
ArchangelWTF
force-pushed
the
fix/media3
branch
from
2283363
to
8b22bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Libraries Version (eg: 23.3.0):
Does this change any of the generated binding API's?
Yes, especially due to Media3 now binding with MAUI's binding generator. (See factory changes)
Describe your contribution
Allows MediaSources to now be set correctly, disables binding for Xamarin.Forms on Media3 so that it's no longer required to remove MediaSourceFactory, bring in ConcatenatingMediaSource2, MergingMediaSource & WrappingMediaSource which were originally removed.
Fixes: #954