-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(hi): add Astro v5 banner in Hindi #9433
i18n(hi): add Astro v5 banner in Hindi #9433
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Thank you, and what a cool first contribution to the docs to make, @apatel369 ! One of our maintainers will review this shortly, but in fact, this banner appears on a second page in docs, AND there is another note with the link to the upgrade guide too. Would you mind adding these to this PR? How our Translators normally work is they notice an English PR that has merged, and then they replicate it in their language. You linked the correct PR where this change was added, but if you check that PR you'll see there are more changes made in that PR. You can see all the changes made in the "Files changed" view of the PR: https://github.com/withastro/docs/pull/9387/files It would be great if you could add all those changes together at once! 🙌 |
@sarah11918 Thanks for reviewing my changes. Added Note in PR Description. If I understand correctly you are referring to changes for content-collections.mdx and upgrade-astro.mdx. Is there anything else I need to do here? |
@apatel369 D'oh, my mistake! Of course you're right and that makes perfect sense! 😄 This is the only change applicable for your language, so it's perfect like this. No changes needed, and ready for a review when we can get to it! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR could not have been sooner 🔥 Welcome to Team Docs Arpan 🥳
Thanks! The Astro Team has been incredibly welcoming. I loved how quickly Sarah and Atharva reviewed my PR. |
Description (required)
Add Astro v5 banner to Hindi version of
getting-started.mdx
Related issues
9387
NOTE WHEN MERGING
After merging, update the beta branch, adding a commit to revert this pr