Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(hi): add Astro v5 banner in Hindi #9433

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

apatel369
Copy link
Contributor

@apatel369 apatel369 commented Sep 17, 2024

Description (required)

Add Astro v5 banner to Hindi version of getting-started.mdx

Related issues
9387

NOTE WHEN MERGING
After merging, update the beta branch, adding a commit to revert this pr

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2c177d7
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66eaf166cfccf6000891dcff
😎 Deploy Preview https://deploy-preview-9433--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 17, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
hi getting-started.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Member

Thank you, and what a cool first contribution to the docs to make, @apatel369 !

One of our maintainers will review this shortly, but in fact, this banner appears on a second page in docs, AND there is another note with the link to the upgrade guide too. Would you mind adding these to this PR?

How our Translators normally work is they notice an English PR that has merged, and then they replicate it in their language. You linked the correct PR where this change was added, but if you check that PR you'll see there are more changes made in that PR. You can see all the changes made in the "Files changed" view of the PR: https://github.com/withastro/docs/pull/9387/files

It would be great if you could add all those changes together at once! 🙌

@apatel369
Copy link
Contributor Author

apatel369 commented Sep 18, 2024

@sarah11918 Thanks for reviewing my changes. Added Note in PR Description.

If I understand correctly you are referring to changes for content-collections.mdx and upgrade-astro.mdx.
But those files don't exist for hindi. That's why those changes are absent in my PR.

Is there anything else I need to do here?

Screenshot 2024-09-17 at 10 24 03 PM

@sarah11918
Copy link
Member

@apatel369 D'oh, my mistake! Of course you're right and that makes perfect sense! 😄

This is the only change applicable for your language, so it's perfect like this. No changes needed, and ready for a review when we can get to it! Thank you!

Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR could not have been sooner 🔥 Welcome to Team Docs Arpan 🥳

@at-the-vr at-the-vr merged commit 61871c6 into withastro:main Sep 18, 2024
10 checks passed
@apatel369
Copy link
Contributor Author

This PR could not have been sooner 🔥 Welcome to Team Docs Arpan 🥳

Thanks! The Astro Team has been incredibly welcoming. I loved how quickly Sarah and Atharva reviewed my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants