refactor: rework supportedAstroFeatures #11806
Conversation
🦋 Changeset detectedLatest commit: d835c43 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| supportKind: AdapterSupport, | ||
| adapterMessage?: string, | ||
| ) { | ||
| switch (supportKind) { |
There was a problem hiding this comment.
Merged the different functions into one here that way you get an exhaustive check on the switch, felt nicer
| export type AdapterSupportsKind = | ||
| (typeof AdapterFeatureStability)[keyof typeof AdapterFeatureStability]; |
There was a problem hiding this comment.
Moved the source of truth from the type to the runtime check here, that way they're always accurate
| } | ||
| if (supportValue === AdapterFeatureStability.STABLE) { | ||
| return true; | ||
| } else if (hasCorrectConfig()) { |
There was a problem hiding this comment.
The previous check here was weird, it only checked if the config was correct for the unsupported value, but you need to always check it, otherwise you get warning for every experimental feature, even the ones you don't use?
github-actions
bot
added
pkg: integration
There was a problem hiding this comment.
We have moved the adapter to https://github.com/withastro/adapters, so this PR can't be merged here anymore.
I would offer to port over the changes to the new repo for you, just let me know if you want me to do that.
|
@Princesseuh do you want me to port over the changes of the adapter related code, or are you going to do it yourself? |
github-actions
bot
added
docs pr
and removed
pkg: integration
|
ill do it myself, no worries |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Princesseuh
dismissed
alexanderniebuhr’s stale review
will port the changes to the adapters repo
Changes
supportedAstroFeatureson adapters is quite static, and the reality is often more nuanced. For instance, for Sharp, sometimes it's not supported with the default configuration, but with certain config it can be, but even then, it might only be on pre-rendered pages etc.This PR does a few things:
assetssection,"limited"valueTesting
Updated tests, and the current ones should pass
Docs
Will do!