-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert AWP to typescript #198
Labels
enhancement
New feature or request
Comments
Closed
7 tasks
This was referenced Jan 23, 2024
Closed
ikreymer
pushed a commit
to webrecorder/replayweb.page
that referenced
this issue
Feb 7, 2024
Preparation for webrecorder/archiveweb.page#198 / webrecorder/archiveweb.page#199. ## Changes - Organizes published files more cleanly, using `dist/types` folder as the target for type declarations and sourcemaps - Configures type field in `package.json` - Updates ESLint & its config - Sets up type-informed linting rules mirroring browsertrix - Adds a bunch of other useful eslint and eslint-typescript rules, and applies auto-fixes to the codebase - Cleans up a bunch of types throughout the codebase, particularly parts of the code used by ArchiveWebPage - Changes `ItemIndex#_deleting` from `private` to `protected` so that a part of AWP that extends it can do so properly - Makes a bunch of previously-implied [non-null assertions](https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#non-null-assertion-operator-postfix-) explicit - Updates `URLResource` and `ItemType` types (and renames `Item` → `ItemType` to disambiguate from the `Item` class) - Removes `node-sass` and replaces it with `sass-embedded` for much quicker installs and compilation
This was referenced Jun 18, 2024
emma-sg
added a commit
to webrecorder/replayweb.page
that referenced
this issue
Jun 19, 2024
Closes #337 Blocks webrecorder/archiveweb.page#198 Adds a dedicated `misc` export, as well as explicitly exporting the `electron-*` files and the `index.html` file. This restricts imports to only these files, and allows us to not have to exactly match webpack configs between RWP and AWP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Archiveweb.page currently imports from replayweb.page
src
. We'll need to do a minimum typescript conversion in order to enable imports from rwp v2.The text was updated successfully, but these errors were encountered: