Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How will the feature name be displayed? #6

Closed
foolip opened this issue May 31, 2024 · 6 comments
Closed

How will the feature name be displayed? #6

foolip opened this issue May 31, 2024 · 6 comments

Comments

@foolip
Copy link
Collaborator

foolip commented May 31, 2024

I have heard from @atopal that this widget will include the name of the feature for situation where it's not clear in context what the feature being referred to is. Is there a mockup for what this will look like?

I'm asking for two reasons:

  • Does it place a limit on the length of feature names?
  • Does it need to support referring to a part of a feature (by BCD key) and show a name for that?

The second question is the most important one to me, because it would constrain how we can solve the problem of evolving features in web-features.

@devnook
Copy link
Collaborator

devnook commented Jun 4, 2024

Hi @foolip
The displayed name is based on the "name" field in the web-features API. E.g. https://api.webstatus.dev/v1/features/set
I think the best place to discuss and work on the right name disambiguation is then the webstatus repo.

Re: Name length - the widget is responsive so I don't limit the length in any way.
Re: BCD keys - this widget only shows what is available in webstatus api. I assume it's only web-features data granularity and no BCD data is available. @jcscottiii can you confirm?

@foolip
Copy link
Collaborator Author

foolip commented Jun 4, 2024

@devnook do you have a screenshot of what it will look like with a relatively long name like "Web authentication easy public key access"?

@devnook
Copy link
Collaborator

devnook commented Jun 4, 2024

Screenshot 2024-06-04 at 12 39 21

(I see "newly available" badge causes small disalignment, will fix.)

@devnook
Copy link
Collaborator

devnook commented Jun 4, 2024

@jcscottiii
Copy link
Collaborator

Re: BCD keys - this widget only shows what is available in webstatus api. I assume it's only web-features data granularity and no BCD data is available. @jcscottiii can you confirm?

That is correct that the webstatus API does not ingest or expose the BCD keys.

@foolip I think solving GoogleChrome/webstatus.dev#322 in the API and having this widget adjust to the redirect would solve your second question regarding the evolving nature of web features data, right?

@foolip
Copy link
Collaborator Author

foolip commented Jun 5, 2024

Thank you @devnook! I see the widget can be any width, where I had imagined a fixed width. But in any case the answer is that the name can wrap lines.

@jcscottiii in this issue I wasn't concerned about redirects caused by a change of identifier. It's about the name and in particular what the displayed name would be if the widget is for a single BCD key and not a whole feature.

Since the widget will use data from webstatus.dev and the BCD keys aren't even used, there's no problem here. Thanks both!

@foolip foolip closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants