Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Visual bug Google login redirect briefly shows error 500 #69

Open
peter-tanner opened this issue Aug 24, 2022 · 2 comments
Open
Labels
bug Something isn't working frontend Frontend-specific Issues

Comments

@peter-tanner
Copy link
Member

Describe the bug

An error code is shown when logging on in the bottom right corner.
This is only meant to show when login is unsuccessful, but every time error 500 is shown briefly regardless of whether the login failed.

To Reproduce

Steps to reproduce the behavior:

  1. Login as normal
  2. After being redirected back from Google, an error code will briefly show in the bottom right.

Expected behavior

Error only shows when login failed

Other

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
I think this is due to a second react render occurring, which sends the login token twice. The first time this succeeds but the same token is sent a second time resulting in the error.

@peter-tanner peter-tanner added bug Something isn't working frontend Frontend-specific Issues labels Aug 24, 2022
@frinzekt
Copy link
Member

You seem to be correct about that... Notice this https://sentry.io/organizations/uwa-system-health-lab/issues/3527123937/?project=6667527&query=is%3Aunresolved

there's an alert of 500 coming from the server because of it

@frinzekt
Copy link
Member

I have first encountered it sometime in #61 ... i would have thought it would fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend-specific Issues
Projects
None yet
Development

No branches or pull requests

2 participants