USWDS-Site - Bug: UnLighthouse.dev ARIA

[mgifford]

Describe the bug

I ran https://unlighthouse.dev/ on the https://designsystem.digital.gov/ site and discovered a few accessibility problems. As I said 2147 , it is really quite good, seems that there are a few here:

The troublesome domains seem to be under /together /patterns & /next

Steps to reproduce the bug

From the command line run:
% npx unlighthouse --site https://designsystem.digital.gov/

and sort the results by accessibility & ARIA.

Expected Behavior

There shouldn't be any ARIA errors.

Screenshots

No response

System setup

No response

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct.
• I checked the current issues for duplicate bug reports.

[amyleadem]

Confirming that unlighthouse does flag accessibility errors on 12 of our pages. The tool scanned 156 pages. The lowest accessibility score it flagged was 92. The overall accessibility score for the site was 100.

These are all of the pages where an accessibility score of less than 100 was reported. The errors seem confined to /next, /together, and /patterns:

• https://designsystem.digital.gov/next/findings/benefits/ (Score: 92)
  • Role value not valid on citation region. role="doc-endnotes", role="doc-endnote"
• https://designsystem.digital.gov/next/ (Score: 98)
  • Color contrast issue, also flagged in USWDS-Site - Bug: UnLighthouse.dev Color Contrast Errors #2147
• https://designsystem.digital.gov/next/findings/community/ (Score: 98)
  • Color contrast issue, also flagged in USWDS-Site - Bug: UnLighthouse.dev Color Contrast Errors #2147
• https://designsystem.digital.gov/next/findings/team/ (Score: 98)
  • Color contrast issue, also flagged in USWDS-Site - Bug: UnLighthouse.dev Color Contrast Errors #2147
• https://designsystem.digital.gov/next/looking-ahead/ (Score: 92)
  • Role value not valid on citation region. role="doc-endnotes", role="doc-endnote"
• https://designsystem.digital.gov/next/introduction/ (Score: 92)
  • Role value not valid on citation region. role="doc-endnotes", role="doc-endnote"
• https://designsystem.digital.gov/next/findings/improve/ (Score: 98)
  • Color contrast issue, also flagged in USWDS-Site - Bug: UnLighthouse.dev Color Contrast Errors #2147
• https://designsystem.digital.gov/patterns/create-a-user-profile/race-and-ethnicity/ (Score: 93)
  • [aria-*] attributes do not match their roles in component code fieldset. (Likely the aria-multiselectable="true" attribute)
• https://designsystem.digital.gov/patterns/select-a-language/language-preferences/ (Score: 94)
  • [aria-*] attributes do not match their roles in component code fieldset. (Likely the aria-multiselectable="true" attribute)
• https://designsystem.digital.gov/together/get-involved/ (Score: 92)
  • Role value not valid on citation region. role="doc-endnotes", role="doc-endnote"
• https://designsystem.digital.gov/together/findings/ (Score: 92)
  • Role value not valid on citation region. role="doc-endnotes", role="doc-endnote"
• https://designsystem.digital.gov/together/ (Score: 92)
  • Role value not valid on citation region. role="doc-endnotes", role="doc-endnote"

[amyleadem]

This issue includes the color contrast errors found in #2147

[mejiaj]

@amyleadem @mgifford thanks for looking into this.

It's hard to tell what the scope of issues and possible fixes are. What are the most glaring errors and what types of fixes are we looking at? We should break this issue up if level of effort is high.

[amyleadem]

@mejiaj @mgifford I have added some notes to my earlier comment with specifics on the flagged errors. It seems as there are only three errors shared across these pages. They all seem like fixes that require a relatively low level of effort.

1. Color contrast issues on some /next pages (also flagged in USWDS-Site - Bug: UnLighthouse.dev Color Contrast Errors #2147)
2. Invalid roles on citation notes
3. Mismatched aria roles in component code samples on a couple patterns pages