Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing on some architectures #232

Open
juliangilbey opened this issue Mar 8, 2024 · 3 comments
Open

Test failing on some architectures #232

juliangilbey opened this issue Mar 8, 2024 · 3 comments

Comments

@juliangilbey
Copy link

mystic/tests/test_collapse.py fails at line 177 on several architectures on Debian (see https://tracker.debian.org/pkg/mystic): these include armel, armhf, i386 and ppc64el. Running the test manually, as the error message is quite uninformative, we find that on i386:

>>> ct.collapse_position(m, mask=((0,1,2),((0,1),(1,2),(0,2))))
((1, 1, 2), ((0, 2), (0, 1), (1, 2)))
>>> x = ct.collapse_position(m, mask=((0,1,2),((0,1),(1,2),(0,2))))
>>> x == ((1,1,2), ((0,1),(0,2),(1,2)))
False

The order of the elements in the second tuple has changed.

The test succeeds on other architectures (amd64, arm64, s390x), so it seems that there is something flaky about the order of the result here.

@mmckerns
Copy link
Member

mmckerns commented Aug 1, 2024

Hmmm... that's odd.

@juliangilbey
Copy link
Author

Quite! I don't understand what the code's doing (or trying to do) well enough to have any idea what causing this issue, or whether it is a problem.

(If the tests were written using pytest or even unittest, I would be able to test all of the tests and report on any others that also fail. As it is, though, it gives up at the first error, so there may well be other failing tests hiding after this one...)

@mmckerns
Copy link
Member

mmckerns commented Aug 9, 2024

the order of the results is actually irrelevant, so I think I could compare a set so order is not important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants