Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify fails for max and other basic functions #127

Open
mmckerns opened this issue Feb 27, 2020 · 3 comments
Open

simplify fails for max and other basic functions #127

mmckerns opened this issue Feb 27, 2020 · 3 comments

Comments

@mmckerns
Copy link
Member

simplify fails to simplify equations with max, abs and other simple functions:

max([abs(x0 - x2), abs(x1 - x3)]) <= 5
max([abs(x0 - x1), abs(x2 - x3)]) <= 5

Currently, mean, var, and some other basic functions work. Thus, the above should be made to work as well.

@mmckerns
Copy link
Member Author

mmckerns commented Feb 27, 2020

Side note: This fails to simplify:
x0*x2*x4 + x1*x2*x5+ x0*x3*x6 + x1*x3*x7 == 0.0
However, this succeeds:
x0*x2*x4 + x0*x3*x6 == -(x1*x3*x7 + x1*x2*x5)
Both should work.

Wow... replacing 0.0 with 0 seems to work. c3a6117 fixes this, but not the main issue.

@mmckerns
Copy link
Member Author

abs added to simplify in f2f1633. It was gnarly.

@mmckerns mmckerns changed the title simplify fails for max, abs, and some basic functions simplify fails for max and other basic functions Jun 12, 2021
@mmckerns
Copy link
Member Author

split off abs to it's own ticket (#136)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant